prosemirror/prosemirror-dropcursor
1
0
Fork 0
Code Pull requests Activity

Fix width and height when CSS transform scale is not 1 #20

Merged
xuejian97 merged 3 commits from fix/height-and-width into master 2023-09-22 13:29:31 +02:00
Conversation 3 Commits 3 Files changed 1 +2 -2
xuejian97 commented 2023-09-21 18:40:11 +02:00 (Migrated from github.com)
Copy link
No description provided.
marijnh commented 2023-09-22 12:07:30 +02:00 (Migrated from github.com)
Copy link

There's no need to make this conditional on isBlock. In the top if, that is always true. In the bottom one, we are always creating a vertical cursor.

There's no need to make this conditional on `isBlock`. In the top `if`, that is always true. In the bottom one, we are always creating a vertical cursor.
xuejian97 commented 2023-09-22 12:51:39 +02:00 (Migrated from github.com)
Copy link

There's no need to make this conditional on isBlock. In the top if, that is always true. In the bottom one, we are always creating a vertical cursor.

My mistake. Fixed it.

> There's no need to make this conditional on `isBlock`. In the top `if`, that is always true. In the bottom one, we are always creating a vertical cursor. My mistake. Fixed it.
marijnh commented 2023-09-22 13:29:35 +02:00 (Migrated from github.com)
Copy link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-dropcursor!20
No description provided.