add option to specify css className #4

Merged

Chrissi2812 merged 2 commits from add-css-class into master 2019-09-05 16:41:02 +02:00

Conversation 2 Commits 2 Files changed 2 +10 -2

Chrissi2812 commented 2019-03-07 09:59:45 +01:00 (Migrated from github.com)

Copy link

The only downside is that overriding the width or height via css will not work correctly (mention in documentation?)

Default is currently that it doesn't add any class when not specified.

The only downside is that overriding the width or height via css will not work correctly (mention in documentation?) Default is currently that it doesn't add any class when not specified.

👍 1

marijnh commented 2019-09-05 14:17:06 +02:00 (Migrated from github.com)

Copy link

Apologies for not responding to this forever. I didn't have notifications turned on for this repository.

If you're still interested in this, could you change the property name to just class and mention the feature in the readme?

Apologies for not responding to this forever. I didn't have notifications turned on for this repository. If you're still interested in this, could you change the property name to just `class` and mention the feature in the readme?

Chrissi2812 commented 2019-09-05 16:34:44 +02:00 (Migrated from github.com)

Copy link

@marijnh No problem, had forgotten about it myself ^^
I made the requested changes.

@marijnh No problem, had forgotten about it myself ^^ I made the requested changes.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

prosemirror/prosemirror-dropcursor!4

No description provided.