prosemirror/prosemirror-dropcursor
1
0
Fork 0
Code Pull requests Activity

cursor should always be on the top z-index stack #6

Closed
kapouer wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: prosemirror:master
Conversation 5 Commits 1 Files changed 1 +1 -1
kapouer commented 2019-05-10 10:48:09 +02:00 (Migrated from github.com)
Copy link

All browsers clip a too high value to the max value except firefox <= 3.
Source: https://stackoverflow.com/questions/491052/minimum-and-maximum-value-of-z-index

All browsers clip a too high value to the max value except firefox <= 3. Source: https://stackoverflow.com/questions/491052/minimum-and-maximum-value-of-z-index
kapouer commented 2019-05-10 14:20:10 +02:00 (Migrated from github.com)
Copy link

Number.MAX_SAFE_INTEGER being not IE11-compatible, replaced by highest value reported in the link above.

`Number.MAX_SAFE_INTEGER` being not IE11-compatible, replaced by highest value reported in the link above.
marijnh commented 2019-09-05 14:18:21 +02:00 (Migrated from github.com)
Copy link

(Sorry for not responding earlier—I didn't have notifications turned on for this repository.)

I'm not a fan of adding ridiculously high z-index values. What was the concrete problem that led to this PR?

(Sorry for not responding earlier—I didn't have notifications turned on for this repository.) I'm not a fan of adding ridiculously high z-index values. What was the concrete problem that led to this PR?
kapouer commented 2019-09-05 14:22:15 +02:00 (Migrated from github.com)
Copy link

A very high z-index value in the website stylesheet.
Using the safest highest value seems legit, as the cursor is meant to be on top anyway.

A very high z-index value in the website stylesheet. Using the safest highest value seems legit, as the cursor is meant to be on top anyway.
marijnh commented 2019-09-05 14:34:43 +02:00 (Migrated from github.com)
Copy link

No, I mean, what kind of element was blocking the drop cursor? If something is overlaying the editor, it seems reasonable for that thing to also hide the drop cursor.

No, I mean, what kind of element was blocking the drop cursor? If something is overlaying the editor, it seems reasonable for that thing to also hide the drop cursor.
kapouer commented 2019-09-05 14:42:56 +02:00 (Migrated from github.com)
Copy link

I'm using prosemirror in a document body editor - that's why i didn't consider that use case.
The ability to set a class name would also work, so i'll drop this one.

I'm using prosemirror in a document body editor - that's why i didn't consider that use case. The ability to set a class name would also work, so i'll drop this one.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-dropcursor!6
No description provided.