prosemirror/prosemirror-dropcursor
1
0
Fork 0
Code Pull requests Activity

Only create drop cursor if the view is editable. #8

Closed
cmlenz wants to merge 1 commit from only-create-if-editable into master
pull from: only-create-if-editable
merge into: prosemirror:master
Conversation 2 Commits 1 Files changed 1 +1 -1
cmlenz commented 2019-06-24 13:14:24 +02:00 (Migrated from github.com)
Copy link

Similar to ProseMirror/prosemirror-gapcursor#6 but for the drop cursor.

I would normally create a local var for the view or the state here, now that it's being accessed in the arrow function, but I tried to keep the change minimal. Let me know if that would be preferred.

Similar to ProseMirror/prosemirror-gapcursor#6 but for the drop cursor. I would normally create a local var for the view or the state here, now that it's being accessed in the arrow function, but I tried to keep the change minimal. Let me know if that would be preferred.
cmlenz commented 2019-09-05 13:46:28 +02:00 (Migrated from github.com)
Copy link

@marijnh can this change be integrated or is something missing from the PR?

@marijnh can this change be integrated or is something missing from the PR?
marijnh commented 2019-09-05 14:11:31 +02:00 (Migrated from github.com)
Copy link

Having everybody recompute editable all the time seems wasteful. I'm going to make view.editable public, and attached patch uses that instead.

Having everybody recompute editable all the time seems wasteful. I'm going to make `view.editable` public, and attached patch uses that instead.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-dropcursor!8
No description provided.