prosemirror/prosemirror-gapcursor
1
0
Fork 0
Code Pull requests Activity

allow creation of paragraph in body above/below table #2

Closed
johanneswilm wants to merge 2 commits from master into master
pull from: master
merge into: prosemirror:master
Conversation 1 Commits 2 Files changed 1 +17 -6
johanneswilm commented 2017-10-07 21:09:10 +02:00 (Migrated from github.com)
Copy link

This allows using allowGapCursor = false on nodes higher up to prevent the gap cursor to be placed in them. Also, when inserting inline nodes into blocks that are not Textblock nodes, it doesn't try to directly insert the nodes, but wraps them inside a textblocknode type defined with defaultTextBlock = true in the schema.

This should not be merged directly, as I was missing a lot of knowledge about other situations in which gapcursor is to be used, so I don't know if it is breaking anything for others. Also, it seems like there already is a way to determine which textblock node is the default one, or how content should be wrapped that is being used in other places. At any rate, I hope this serves to show what kinds of additions we would need for our particular usecase.

This allows using `allowGapCursor = false` on nodes higher up to prevent the gap cursor to be placed in them. Also, when inserting inline nodes into blocks that are not Textblock nodes, it doesn't try to directly insert the nodes, but wraps them inside a textblocknode ~type defined with `defaultTextBlock = true` in the schema~. This should not be merged directly, as I was missing a lot of knowledge about other situations in which gapcursor is to be used, so I don't know if it is breaking anything for others. Also, it seems like there already is a way to determine which textblock node is the default one, or how content should be wrapped that is being used in other places. At any rate, I hope this serves to show what kinds of additions we would need for our particular usecase.
marijnh commented 2017-10-13 13:55:14 +02:00 (Migrated from github.com)
Copy link

I hope patch c6824e5 address this.

I hope patch c6824e5 address this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-gapcursor!2
No description provided.