prosemirror/prosemirror-inputrules
1
0
Fork 0
Code Pull requests Activity

Make the maximum match length configurable #1

Closed
kiejo wants to merge 1 commit from master into master
pull from: master
merge into: prosemirror:master
Conversation 7 Commits 1 Files changed 1 +3 -5
kiejo commented 2017-02-21 08:02:45 +01:00 (Migrated from github.com)
Copy link

I have a use case where I need the maximum match length to be bigger than 100 (detecting when a user types in a markdown link which can have a long URL).

I have a use case where I need the maximum match length to be bigger than 100 (detecting when a user types in a markdown link which can have a long URL).
marijnh commented 2017-02-21 09:01:44 +01:00 (Migrated from github.com)
Copy link

What length did you end up using?

What length did you end up using?
kiejo commented 2017-02-21 11:02:02 +01:00 (Migrated from github.com)
Copy link

I ended up using 200.

I ended up using 200.
marijnh commented 2017-02-21 11:07:32 +01:00 (Migrated from github.com)
Copy link

Would just bumping up the default length to 500 work for you?

Would just bumping up the default length to 500 work for you?
kiejo commented 2017-02-21 11:18:28 +01:00 (Migrated from github.com)
Copy link

Yes, that would definitely work for the use cases I currently have!

Yes, that would definitely work for the use cases I currently have!
marijnh commented 2017-02-21 11:20:26 +01:00 (Migrated from github.com)
Copy link

Done in attached patch. Convention over configuration and all that (though I might come back to it if someone actually comes up with a rule that needs a match longer than 500)

Done in attached patch. Convention over configuration and all that (though I might come back to it if someone actually comes up with a rule that needs a match longer than 500)
kiejo commented 2017-02-21 11:21:24 +01:00 (Migrated from github.com)
Copy link

Thanks, sounds good :) Would be great to have new minor release with the patch.

Thanks, sounds good :) Would be great to have new minor release with the patch.
marijnh commented 2017-02-21 11:28:42 +01:00 (Migrated from github.com)
Copy link

Done!

Done!
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-inputrules!1
No description provided.