prosemirror/prosemirror-inputrules
1
0
Fork 0
Code Pull requests Activity

added inCode flag #8

Closed
bobzel wants to merge 2 commits from inputRulesForCodeBlocks into master
pull from: inputRulesForCodeBlocks
merge into: prosemirror:master
Conversation 6 Commits 2 Files changed 1 +14 -3
bobzel commented 2024-01-29 17:39:19 +01:00 (Migrated from github.com)
Copy link

added inCode flag to inputRule specs to allow inputRules to selectively apply to code blocks.

added inCode flag to inputRule specs to allow inputRules to selectively apply to code blocks.
marijnh (Migrated from github.com) reviewed 2024-01-29 17:54:53 +01:00
src/inputrules.ts
@ -35,12 +36,17 @@ export class InputRule {
/// When set to false,
marijnh (Migrated from github.com) commented 2024-01-29 17:54:53 +01:00
Copy link

I don't think this should be a string.

I don't think this should be a string.
marijnh (Migrated from github.com) reviewed 2024-01-29 17:56:11 +01:00
src/inputrules.ts
@ -11,6 +11,7 @@ export class InputRule {
marijnh (Migrated from github.com) commented 2024-01-29 17:56:11 +01:00
Copy link

Could you make this boolean | "only", so people can also explicitly provide false?

Could you make this `boolean | "only"`, so people can also explicitly provide `false`?
bobzel (Migrated from github.com) reviewed 2024-01-29 18:24:10 +01:00
src/inputrules.ts
@ -35,12 +36,17 @@ export class InputRule {
/// When set to false,
bobzel (Migrated from github.com) commented 2024-01-29 18:24:10 +01:00
Copy link

yes, you're right, don't know how I changed that.

yes, you're right, don't know how I changed that.
bobzel (Migrated from github.com) reviewed 2024-01-29 18:24:23 +01:00
src/inputrules.ts
@ -11,6 +11,7 @@ export class InputRule {
bobzel (Migrated from github.com) commented 2024-01-29 18:24:23 +01:00
Copy link

done.

done.
bobzel commented 2024-01-30 04:26:10 +01:00 (Migrated from github.com)
Copy link

Just curious since this is my first pull request -- how long should I expect it to take to have it merged? days, weeks, months?
Thanks and sorry for being so naive to this process.

Just curious since this is my first pull request -- how long should I expect it to take to have it merged? days, weeks, months? Thanks and sorry for being so naive to this process.
marijnh commented 2024-01-30 10:19:01 +01:00 (Migrated from github.com)
Copy link

Merged as 66d47eaa48, tidied up in a993c59c11. Released as part of prosemirror-inputrules 1.4.0

Merged as 66d47eaa489ff4eab, tidied up in a993c59c111dc5973102f55. Released as part of prosemirror-inputrules 1.4.0

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-inputrules!8
No description provided.