prosemirror/prosemirror-keymap
1
0
Fork 0
Code Pull requests Activity

Enforce min version of w3c-keyname to be 1.1.8 #1

Closed
d4rkr00t wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: prosemirror:master
Conversation 7 Commits 1 Files changed 1 +1 -1
d4rkr00t commented 2018-02-23 01:11:32 +01:00 (Migrated from github.com)
Copy link

Version below 1.1.8 has an issue when shortcuts with the Shift key (e.g. CMD+Shift+Z) is not working properly in Chrome (maybe other browsers too).

It's happening because w3c-keyname returns z (as a lowercase z) instead of Z (uppercase Z) which is breaking those shortcuts.

Even though version 1.1.8 satisfies specified semver range of '^1.1.0' tooling like yarn is not updating existing yarn locks... Solution could be to manually amend yarn.lock/package-lock.json, but I think it makes total sense to just force it in a package...

Version below 1.1.8 has an issue when shortcuts with the Shift key (e.g. CMD+Shift+Z) is not working properly in Chrome (maybe other browsers too). It's happening because w3c-keyname returns z (as a lowercase z) instead of Z (uppercase Z) which is breaking those shortcuts. Even though version 1.1.8 satisfies specified semver range of '^1.1.0' tooling like yarn is not updating existing yarn locks... Solution could be to manually amend yarn.lock/package-lock.json, but I think it makes total sense to just force it in a package...
marijnh commented 2018-02-23 08:39:51 +01:00 (Migrated from github.com)
Copy link

Solution could be to manually amend yarn.lock/package-lock.json,

I haven't really worked with yarn a lot, but is that really the main way to do this? Isn't yarn upgrade an easier way?

I am not really happy about the idea of tracking the current versions of dependencies in all modules—that'd add a lot of busywork.

> Solution could be to manually amend yarn.lock/package-lock.json, I haven't really worked with yarn a lot, but is that really the main way to do this? Isn't `yarn upgrade` an easier way? I am not really happy about the idea of tracking the current versions of dependencies in all modules—that'd add a lot of busywork.
d4rkr00t commented 2018-02-23 10:31:46 +01:00 (Migrated from github.com)
Copy link

Yeah, it seems like the only way, because for the project that has this issue it's a huge chain of dependencies e.g.: project -> editor (our editor built on top of prosemirror) -> prosemirror-keymap -> w3c-keyname. In this case w3c-keyname is a transitive dependency somewhere deep down dependency tree. They can update/upgrade our abstraction (editor), but because old version of w3c-keyname still satisfies semver range in prosemirror-keymap yarn is not touching it...

Yeah, it seems like the only way, because for the project that has this issue it's a huge chain of dependencies e.g.: `project -> editor (our editor built on top of prosemirror) -> prosemirror-keymap -> w3c-keyname`. In this case w3c-keyname is a transitive dependency somewhere deep down dependency tree. They can update/upgrade our abstraction (editor), but because old version of w3c-keyname still satisfies semver range in prosemirror-keymap yarn is not touching it...
marijnh commented 2018-02-23 10:33:41 +01:00 (Migrated from github.com)
Copy link

but because old version of w3c-keyname still satisfies semver range in prosemirror-keymap yarn is not touching it...

Well that's just terrible. What happens when you yarn upgrade w3c-keyname?

> but because old version of w3c-keyname still satisfies semver range in prosemirror-keymap yarn is not touching it... Well that's just terrible. What happens when you `yarn upgrade w3c-keyname`?
marijnh commented 2018-02-23 10:36:26 +01:00 (Migrated from github.com)
Copy link

There's some discussion about this at https://github.com/yarnpkg/rfcs/pull/54 , but it doesn't seem to be moving very quickly.

There's some discussion about this at https://github.com/yarnpkg/rfcs/pull/54 , but it doesn't seem to be moving very quickly.
d4rkr00t commented 2018-02-23 11:03:59 +01:00 (Migrated from github.com)
Copy link

Well that's just terrible. What happens when you yarn upgrade w3c-keyname?

Nothing...

> Well that's just terrible. What happens when you yarn upgrade w3c-keyname? Nothing...
marijnh commented 2018-02-23 19:47:12 +01:00 (Migrated from github.com)
Copy link

Not too happy about the prospect of having to track transitive dependencies with new releases, but I've merged this and released it as 1.0.1, since apparently the package managers won't help here.

Not too happy about the prospect of having to track transitive dependencies with new releases, but I've merged this and released it as 1.0.1, since apparently the package managers won't help here.
d4rkr00t commented 2018-02-24 09:58:51 +01:00 (Migrated from github.com)
Copy link

Thank you. I'm not happy having to ask you to do that either :( But it seems like the only reliable way to enforce that right now :(

Thank you. I'm not happy having to ask you to do that either :( But it seems like the only reliable way to enforce that right now :(

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-keymap!1
No description provided.