prosemirror/prosemirror-keymap
1
0
Fork 0
Code Pull requests Activity

Check for ctrlKey in keyCode fallback #3

Closed
nathf wants to merge 1 commit from master into master
pull from: master
merge into: prosemirror:master
Conversation 2 Commits 1 Files changed 2 +7 -1
nathf commented 2019-07-24 03:58:16 +02:00 (Migrated from github.com)
Copy link

Addresses: https://github.com/ProseMirror/prosemirror/issues/957

Addresses: https://github.com/ProseMirror/prosemirror/issues/957
marijnh commented 2019-07-26 09:44:53 +02:00 (Migrated from github.com)
Copy link

I'd prefer not to do this, as it can lead to undesirable matches (say you have a querz keyword configured as query, and you're pressing the physical ctrl-z, which is bound to ctrl-y — this should not match the undo handler)

I'd prefer not to do this, as it can lead to undesirable matches (say you have a querz keyword configured as query, and you're pressing the physical ctrl-z, which is bound to ctrl-y — this should not match the undo handler)
nathf commented 2019-07-29 04:38:54 +02:00 (Migrated from github.com)
Copy link

Thanks @marijnh!

Thanks @marijnh!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-keymap!3
No description provided.