Idea for making keydownHandler reusable outside ProseMirror

ccorcos commented

2021-02-05 22:45:05 +01:00

(Migrated from github.com)

Hey there, since I'm using ProseMirror heavily in my application, I figured it makes sense to use the same keyboard shortcut handling in the rest of my application (navigating menus and stuff outside of ProseMirror).

I was hoping this would end up with a cleaner abstraction (its a little gross having to call callBindingsWithView every time), but maybe you might think of better way to do it so I can reuse this logic elsewhere.

Cheers,

Chet

Hey there, since I'm using ProseMirror heavily in my application, I figured it makes sense to use the same keyboard shortcut handling in the rest of my application (navigating menus and stuff outside of ProseMirror). I was hoping this would end up with a cleaner abstraction (its a little gross having to call `callBindingsWithView` every time), but maybe you might think of better way to do it so I can reuse this logic elsewhere. Cheers, Chet

marijnh commented

2021-02-08 12:03:16 +01:00

(Migrated from github.com)

Sorry, but I don't think this is a good idea. It's going to copy, bind, and normalize all handlers on every key press. We could have set up the abstractions differently to allow this more elegantly, but at this point I think just duplicating the logic you need in your own code is the more reasonable approach.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Rows
Columns

Idea for making keydownHandler reusable outside ProseMirror #5

Pull request closed