Escape ! in front of a link mark, fixes #73 #74

Closed

susnux wants to merge 1 commit from fix/escape-exclam-links into master

susnux commented

2022-06-26 15:43:46 +02:00

(Migrated from github.com)

Ensure ! character is escaped if used in front of a link mark to prevent misinterpreting it as a image node.
So this will resolve #73.

Also added a test for this behavior and did some minor test
cleanup (unify indention).

Not sure if this is the cleanest solution but it works.

Ensure `!` character is escaped if used in front of a link mark to prevent misinterpreting it as a image node. So this will resolve #73. Also added a test for this behavior and did some minor test cleanup (unify indention). Not sure if this is the cleanest solution but it works.

susnux commented

2022-07-04 18:55:53 +02:00

(Migrated from github.com)

@marijnh what do you think about this? Do you think it can be merged?

marijnh commented

2022-07-05 13:27:34 +02:00

(Migrated from github.com)

I've pushed a somewhat different patch github.com/ProseMirror/prosemirror-markdown@395c6b7f8c

I've pushed a somewhat different patch https://github.com/ProseMirror/prosemirror-markdown/commit/395c6b7f8ce5521d3e7aed08d24f35ec01e73a2e

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

prosemirror/prosemirror-markdown!74

No description provided.

Rows
Columns