prosemirror/prosemirror-markdown
1
0
Fork 0
Code Issues 3 Pull requests Activity

Check content of code blocks for any sequence of backticks #89

Merged
susnux merged 1 commit from fix/code_block into master 2022-10-28 13:30:03 +02:00
Conversation 3 Commits 1 Files changed 2 +11 -2
susnux commented 2022-10-27 21:40:39 +02:00 (Migrated from github.com)
Copy link
  • Resolves: #88

CommonMark allows a sequence of backticks within a code block, but the fence has to be at least one backtick longer than the sequence within. See the linked issue for a detailed explanation.

* Resolves: #88 --- CommonMark allows a sequence of backticks within a code block, but the fence has to be at least one backtick longer than the sequence within. See the linked issue for a detailed explanation.
marijnh commented 2022-10-28 09:15:04 +02:00 (Migrated from github.com)
Copy link

We're still targeting browsers that don't have String.repeat. But it seems you can easily avoid using that by appending an extra backtick to the matched string itself.

We're still targeting browsers that don't have `String.repeat`. But it seems you can easily avoid using that by appending an extra backtick to the matched string itself.
susnux commented 2022-10-28 11:16:50 +02:00 (Migrated from github.com)
Copy link

We're still targeting browsers that don't have String.repeat. But it seems you can easily avoid using that by appending an extra backtick to the matched string itself.

Ok rewrote it without String.repeat.

> We're still targeting browsers that don't have `String.repeat`. But it seems you can easily avoid using that by appending an extra backtick to the matched string itself. Ok rewrote it without `String.repeat`.
marijnh commented 2022-10-28 13:30:18 +02:00 (Migrated from github.com)
Copy link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-markdown!89
No description provided.