prosemirror/prosemirror-markdown
1
0
Fork 0
Code Issues 3 Pull requests Activity

Allow to specify hard break node name #94

Merged
aguingand merged 1 commit from custom-hard-break-name into master 2023-05-09 17:23:13 +02:00
Conversation 3 Commits 1 Files changed 1 +9 -6
aguingand commented 2023-05-09 17:05:37 +02:00 (Migrated from github.com)
Copy link

I'm the maintainer of tiptap-markdown, and I use prosemirror-markdown to serialize content into markdown string.
For now, I'm overriding the schema node name to "hard_break" but it's not really satisfying.

My proposal is to add hardBreakNodeName to the serializer options with "hard_break" by default.

I'm the maintainer of [tiptap-markdown](https://github.com/aguingand/tiptap-markdown), and I use prosemirror-markdown to serialize content into markdown string. For now, I'm overriding the schema node name to `"hard_break"` but it's not really satisfying. My proposal is to add `hardBreakNodeName` to the serializer options with `"hard_break"` by default.
👍 1
marijnh commented 2023-05-09 17:23:22 +02:00 (Migrated from github.com)
Copy link

Thanks, that looks reasonable.

Thanks, that looks reasonable.
👍 2
marijnh commented 2023-05-11 09:15:44 +02:00 (Migrated from github.com)
Copy link

This could have used a bit more care—see https://github.com/ProseMirror/prosemirror-markdown/pull/96 . But I guess that's on me for not testing it locally before merging.

This could have used a bit more care—see https://github.com/ProseMirror/prosemirror-markdown/pull/96 . But I guess that's on me for not testing it locally before merging.
aguingand commented 2023-05-11 11:28:46 +02:00 (Migrated from github.com)
Copy link

Ouch... sorry, I think I rushed this a little bit. To be honest I tried to build + test the repo before publishing this PR but I only found out now I have to run npm run prepare before npm run test. Have you considered setup a CI (e.g. GH action) ?

Ouch... sorry, I think I rushed this a little bit. To be honest I tried to build + test the repo before publishing this PR but I only found out now I have to run `npm run prepare` before `npm run test`. Have you considered setup a CI (e.g. GH action) ?
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-markdown!94
No description provided.