allow spec.title to be a function #10

Closed
kofifus wants to merge 3 commits from patch-2 into master
kofifus commented 2017-04-17 01:22:47 +02:00 (Migrated from github.com)

allow spec.title to be a function state => string

this allows different title on the same menu item depending on the context, for example an outdent icon which has different title if the current selection is in a list or not

allow spec.title to be a function state => string this allows different title on the same menu item depending on the context, for example an outdent icon which has different title if the current selection is in a list or not
marijnh commented 2017-04-17 21:41:29 +02:00 (Migrated from github.com)

Looks good. Could you update the docs and put spaces around operators?

Looks good. Could you update the docs and put spaces around operators?
kofifus commented 2017-04-18 04:45:07 +02:00 (Migrated from github.com)

done

done
marijnh commented 2017-04-18 10:39:30 +02:00 (Migrated from github.com)

Merged as b36eee4

Merged as b36eee4

Pull request closed

Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-menu!10
No description provided.