prosemirror/prosemirror-menu
1
0
Fork 0
Code Issues 7 Pull requests Activity

Improve ESM support #23

Closed
laurentpellegrino wants to merge 4 commits from pm-esm into master
pull from: pm-esm
merge into: prosemirror:master
Conversation 3 Commits 4 Files changed 2 +13 -7
laurentpellegrino commented 2019-11-08 16:12:16 +01:00 (Migrated from github.com)
Copy link

The latest version of crel (4.0.1) looks backward compatible. It is also written using ES6 features. Unfortunately, it does not make use of ESM exports.

I submitted a PR but got not answers:
https://github.com/KoryNunn/crel/pull/51

In the meantime, I have forked the repository:
https://github.com/prosemirror-esm/crel/tree/crel-esm

and published it on npmjs.

I suggest using this version until official support is provided.

The latest version of crel (4.0.1) looks backward compatible. It is also written using ES6 features. Unfortunately, it does not make use of ESM exports. I submitted a PR but got not answers: https://github.com/KoryNunn/crel/pull/51 In the meantime, I have forked the repository: https://github.com/prosemirror-esm/crel/tree/crel-esm and published it on npmjs. I suggest using this version until official support is provided.
marijnh commented 2019-11-08 22:05:42 +01:00 (Migrated from github.com)
Copy link

Partially merged in 5c8668dae0...85909bb1fde42. Possibly the crel maintainer will respond (though the repo does look pretty inactive). If you can find an equivalent small package that covers the same functionality but does export a module, I'd consider switching. (But it has to be small—I'm a bit picky about dependencies.)

Partially merged in 5c8668dae0...85909bb1fde42. Possibly the crel maintainer will respond (though the repo does look pretty inactive). If you can find an equivalent small package that covers the same functionality but _does_ export a module, I'd consider switching. (But it has to be small—I'm a bit picky about dependencies.)
laurentpellegrino commented 2019-11-08 22:30:44 +01:00 (Migrated from github.com)
Copy link

@marijnh What about re:dom?

It seems to cover the same functionality (and more), the code is less than 2KB, maintained and supports ESM. Last but not least, the usage looks quite the same:

https://redom.js.org/#elements

@marijnh What about [re:dom](https://redom.js.org/)? It seems to cover the same functionality (and more), the code is less than 2KB, maintained and supports ESM. Last but not least, the usage looks quite the same: https://redom.js.org/#elements
marijnh commented 2019-11-09 00:12:21 +01:00 (Migrated from github.com)
Copy link

re:dom is a lot bigger than crel (and does a whole lot of things we don't need), so that's not really what I was looking for.

re:dom is a _lot_ bigger than crel (and does a whole lot of things we don't need), so that's not really what I was looking for.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-menu!23
No description provided.