prosemirror/prosemirror-menu
1
0
Fork 0
Code Issues 7 Pull requests Activity

Mark EditorView and dom.Event as optional in run() #27

Closed
aried3r wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: prosemirror:master
Conversation 2 Commits 1 Files changed 1 +1 -1
aried3r commented 2020-04-16 19:25:48 +02:00 (Migrated from github.com)
Copy link

I believe these are optional.

github.com/ProseMirror/prosemirror-commands@3126d5c625/src/commands.js (L174-L193)

github.com/ProseMirror/prosemirror-menu@9d68b3b755/src/menu.js (L370-L377)

I believe these are optional. https://github.com/ProseMirror/prosemirror-commands/blob/3126d5c625953ba590c5d3a0db7f1009f46f1571/src/commands.js#L174-L193 https://github.com/ProseMirror/prosemirror-menu/blob/9d68b3b75511e9815b2433263329fb2d344e0be8/src/menu.js#L370-L377
marijnh commented 2020-04-16 22:16:58 +02:00 (Migrated from github.com)
Copy link

They are always passed, so they aren't optional arguments. Whether the function uses them is another question, but that's how all JavaScript functions work.

They are always passed, so they aren't optional arguments. Whether the function uses them is another question, but that's how all JavaScript functions work.
aried3r commented 2020-04-16 22:51:25 +02:00 (Migrated from github.com)
Copy link

Ah, yes, of course, thank you!

Ah, yes, of course, thank you!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-menu!27
No description provided.