Fix typescript error #36

Merged

ocavue merged 1 commit from ocavue/type-fix into master 2023-05-05 14:56:45 +02:00

Conversation 0 Commits 1 Files changed 1 +3 -3

ocavue commented 2023-05-05 14:42:13 +02:00 (Migrated from github.com)

Copy link

This PR fixes the following TypeScript error while building:

menu/src/menu.ts(237,19): error TS1345: An expression of type 'void' cannot be tested for truthiness.

The close function now returns a boolean value instead of void.

This PR fixes the following TypeScript error while building: ``` menu/src/menu.ts(237,19): error TS1345: An expression of type 'void' cannot be tested for truthiness. ``` The `close` function now returns a boolean value instead of `void`.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

prosemirror/prosemirror-menu!36

No description provided.