Change the array type in DOMOutputSpec to readonly #73

Merged

lastnigtic merged 1 commit from master into master 2022-07-27 12:12:52 +02:00

Conversation 3 Commits 1 Files changed 1 +1 -1

lastnigtic commented 2022-07-26 06:49:15 +02:00 (Migrated from github.com)

Copy link

As shown above, I think that the type of toDOM2 is assignable to DOMOutputSpec，but in the current version it is not assignable .

Would it be better to add a readonly array type for DOMOutputSpec?

<img width="762" alt="image" src="https://user-images.githubusercontent.com/17680884/180924822-98faf0b8-fad3-43c9-a0c0-e58ecc6f20c9.png"> As shown above, I think that the type of `toDOM2` is assignable to `DOMOutputSpec`，but in the current version it is not assignable . Would it be better to add a readonly array type for `DOMOutputSpec`?

marijnh commented 2022-07-26 14:16:20 +02:00 (Migrated from github.com)

Copy link

Could you change this to just have the readonly array, not both readonly and read-write, in the type?

Could you change this to just have the readonly array, not both readonly and read-write, in the type?

lastnigtic commented 2022-07-26 14:48:24 +02:00 (Migrated from github.com)

Copy link

Could you change this to just have the readonly array, not both readonly and read-write, in the type?

Done, please check

> Could you change this to just have the readonly array, not both readonly and read-write, in the type? Done, please check

marijnh commented 2022-07-27 12:13:02 +02:00 (Migrated from github.com)

Copy link

Thanks!

Thanks!

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

prosemirror/prosemirror-model!73

No description provided.