prosemirror/prosemirror-model
1
0
Fork 0
Code Pull requests Activity

Clarify internal attrs type parameters #80

Merged
ocavue merged 1 commit from ocavue/attrs-types into master 2024-05-20 15:57:37 +02:00
Conversation 1 Commits 1 Files changed 1 +3 -3
ocavue commented 2024-05-20 13:20:13 +02:00 (Migrated from github.com)
Copy link

This tiny PR improves some types for internal function, and also fixes an Argument of type 'MarkType' is not assignable to parameter of type 'never'.ts(2345) typescript error. It doesn't affect the external API (i.e. .d.ts files).

This tiny PR improves some types for internal function, and also fixes an `Argument of type 'MarkType' is not assignable to parameter of type 'never'.ts(2345)` typescript error. It doesn't affect the external API (i.e. `.d.ts` files).
marijnh commented 2024-05-20 15:57:07 +02:00 (Migrated from github.com)
Copy link

It's weird how TypeScript behavior for inference of array types keeps changing (TS 5.3.3 is fine with the array in gatherMarks). But these look reasonable — merging.

It's weird how TypeScript behavior for inference of array types keeps changing (TS 5.3.3 is fine with the array in `gatherMarks`). But these look reasonable — merging.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-model!80
No description provided.