prosemirror/prosemirror-model
1
0
Fork 0
Code Pull requests Activity

Clarify the documentation for Node.nodesBetween. #92

Merged
smoores-dev merged 1 commit from fix-nodes-between-docs into master 2026-02-10 08:50:14 +01:00
Conversation 1 Commits 1 Files changed 1 +5 -4
smoores-dev commented 2026-02-09 21:36:31 +01:00 (Migrated from github.com)
Copy link

This method's name is somewhat misleading, and the docs don't currently help clarify. The name and previous docs make it seem as though the callback will only be invoked for nodes that are entirely contained within the range, when in fact it is invoked for all nodes that overlap the range, including nodes that contain the range entirely.

This has tripped me up more than once!

This method's name is somewhat misleading, and the docs don't currently help clarify. The name and previous docs make it seem as though the callback will only be invoked for nodes that are entirely contained within the range, when in fact it is invoked for all nodes that overlap the range, including nodes that contain the range entirely. This has tripped me up more than once!
👍 1
marijnh commented 2026-02-10 08:50:29 +01:00 (Migrated from github.com)
Copy link

Thanks!

Thanks!
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-model!92
No description provided.