prosemirror/prosemirror-schema-list
1
0
Fork 0
Code Pull requests Activity

Add splitListItemKeepMarks command #10

Closed
antonvolkoff wants to merge 2 commits from split-list-with-marks into master
pull from: split-list-with-marks
merge into: prosemirror:master
Conversation 3 Commits 2 Files changed 2 +24 -2
antonvolkoff commented 2022-10-12 15:41:56 +02:00 (Migrated from github.com)
Copy link

This PR adds splitListItemKeepMarks command which replicates a behavior of splitBlockKeepMarks command for lists.

Why?

I was working on the requirements to preserve marks on the new line. I found that splitBlockKeepMarks command to be very useful for it, but could not find similar command for lists.

I think this is an important addition to this package, so it is consistent with the functionality provided by prosemirror-commands.

This PR adds `splitListItemKeepMarks` command which replicates a behavior of [`splitBlockKeepMarks `](https://github.com/ProseMirror/prosemirror-commands/blob/master/src/commands.ts#L331) command for lists. **Why?** I was working on the requirements to preserve marks on the new line. I found that `splitBlockKeepMarks` command to be very useful for it, but could not find similar command for lists. I think this is an important addition to this package, so it is consistent with the functionality provided by [prosemirror-commands](https://github.com/ProseMirror/prosemirror-commands).
marijnh (Migrated from github.com) reviewed 2022-10-12 17:53:22 +02:00
test/test-commands.ts
marijnh (Migrated from github.com) commented 2022-10-12 17:53:22 +02:00
Copy link

This looks like it doesn't actually test the preserving---it doesn't look at what the stored marks are after the command runs.

This looks like it doesn't actually test the preserving---it doesn't look at what the stored marks are after the command runs.
Nantris commented 2024-10-12 06:47:54 +02:00 (Migrated from github.com)
Copy link

I think this is essentially done now, right?

I think this is essentially done now, right?
marijnh commented 2024-10-12 12:21:01 +02:00 (Migrated from github.com)
Copy link

It looks like the author of this never responded to my reviews and I forgot about this PR, but patch 5ab856ab62 implements this command.

It looks like the author of this never responded to my reviews and I forgot about this PR, but patch 5ab856ab625e926d160 implements this command.
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-schema-list!10
No description provided.