prosemirror/prosemirror-search
1
0
Fork 0
Code Issues Pull requests Activity

fix: Fix a bug in replacement in deeply-nested inline nodes with content #7

Closed
massifrg wants to merge 2 commits from dev into main
pull from: dev
merge into: prosemirror:main
Conversation 2 Commits 2 Files changed 2 +11 -3
massifrg commented 2024-07-15 12:24:20 +02:00 (Migrated from github.com)
Copy link

It solves the bug described here, for replacements that happen in inline nodes whose content is made of non-inline nodes (e.g. a footnote that contains blocks, like Note in Pandoc model).

The patch looks for the upper node that has no inline ancestors, and it searches backwards until depth 1:

  let level = $from.depth
  for (let l = level; l > 0; l--)
    if ($from.node(l).isInline) level = l - 1

(I realize I forgot indentation on the third line in my PR, you should fix it, sorry @marijnh )

Maybe this is more efficient (but I have not tested it):

  let level = $from.depth
  for (let l = 1; l <= $from.depth; l++)
    if ($from.node(l).isInline) { level = l - 1; break }
It solves the bug described [here](https://github.com/ProseMirror/prosemirror-search/pull/6#issuecomment-2228124468), for replacements that happen in inline nodes whose content is made of non-inline nodes (e.g. a footnote that contains blocks, like `Note` in [Pandoc model](https://hackage.haskell.org/package/pandoc-types-1.23/docs/Text-Pandoc-Definition.html#t:Inline)). The patch looks for the upper node that has no inline ancestors, and it searches backwards until depth 1: ```ts let level = $from.depth for (let l = level; l > 0; l--) if ($from.node(l).isInline) level = l - 1 ``` (I realize I forgot indentation on the third line in my PR, you should fix it, sorry @marijnh ) Maybe this is more efficient (but I have not tested it): ```ts let level = $from.depth for (let l = 1; l <= $from.depth; l++) if ($from.node(l).isInline) { level = l - 1; break } ```
marijnh commented 2024-07-16 08:44:28 +02:00 (Migrated from github.com)
Copy link

I went with another solution (see attached patch) instead.

I went with another solution (see attached patch) instead.
👍 1
massifrg commented 2024-07-16 10:38:42 +02:00 (Migrated from github.com)
Copy link

A solution with less computations, fine!

Unfortunately that kind of footnotes model is a way of multiplying computations.

Usually you have blocks of blocks, blocks of inlines and, sometimes, inlines of inlines. From roots to leaves.

The Pandoc Note model reopens the cycle, because it's an inline container of blocks, so, in theory, the cycle starts over again. From root to leaves, and then from other roots again.

In one of my documents I have even notes inside notes, and I verified this patch works.

Again, thank you!

A solution with less computations, fine! Unfortunately that kind of footnotes model is a way of multiplying computations. Usually you have blocks of blocks, blocks of inlines and, sometimes, inlines of inlines. From roots to leaves. The Pandoc `Note` model reopens the cycle, because it's an inline container of blocks, so, in theory, the cycle starts over again. From root to leaves, and then from other roots again. In one of my documents I have even notes inside notes, and I verified this patch works. Again, thank you!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-search!7
No description provided.