prosemirror/prosemirror-search
1
0
Fork 1
Code Issues Pull requests Activity

Fix infinite loop on zero-length regex matches #8

Closed
ocavue wants to merge 1 commit from ocavue/prosemirror-search:ocavue-fix-re into main
pull from: ocavue/prosemirror-search:ocavue-fix-re
merge into: prosemirror:main
Conversation 3 Commits 1 Files changed 2 +10 -2
ocavue commented 2026-05-15 18:00:49 +02:00
First-time contributor
Copy link

Patches buildMatchDeco and replaceAll all handle zero-length regex like .? and .*.

How to test:

Without patch:

$ npm run prepare && NODE_OPTIONS="--max-old-space-size=512" npm run test
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

With patch:

$ npm run prepare && NODE_OPTIONS="--max-old-space-size=512" npm run test
  48 passing (15ms)
Patches `buildMatchDeco` and `replaceAll` all handle zero-length regex like `.?` and `.*`. How to test: Without patch: ``` $ npm run prepare && NODE_OPTIONS="--max-old-space-size=512" npm run test FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory ----- Native stack trace ----- ``` With patch: ``` $ npm run prepare && NODE_OPTIONS="--max-old-space-size=512" npm run test 48 passing (15ms) ```
marijn commented 2026-05-16 13:36:21 +02:00
Owner
Copy link

Thanks. Merged as 23525601a0, tweaked in a81de6e161 and 57204875a9

Thanks. Merged as 23525601a0391d, tweaked in a81de6e161b841 and 57204875a99c7
marijn closed this pull request 2026-05-16 13:36:21 +02:00
ocavue commented 2026-05-25 10:34:52 +02:00
Author
First-time contributor
Copy link

@marijn Hey. I noticed that the patch has not yet been released to NPM. Is there anything you would like to tweak (and perhaps I can help) before releasing?

@marijn Hey. I noticed that the patch has not yet been released to NPM. Is there anything you would like to tweak (and perhaps I can help) before releasing?
marijn commented 2026-05-25 13:22:37 +02:00
Owner
Copy link

I've tagged a version 1.1.1 with this patch.

I've tagged a version 1.1.1 with this patch.
❤️ 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-search!8
No description provided.