Always supply an array to node.mark() #10

Closed

saranrapjs wants to merge 1 commit from fix-null-marks into master

pull from: fix-null-marks

merge into: prosemirror:master

prosemirror:main

prosemirror:tracer

Conversation 1 Commits 1 Files changed 1 +1 -1

saranrapjs commented 2017-12-13 00:39:04 +01:00 (Migrated from github.com)

Copy link

This branch fixes a bug where non-marked nodes would needlessly cause a node to be re-created, because node.marksAcross() can return null (but node.mark() expects an array of marks).

This branch fixes a bug where non-marked nodes would needlessly cause a node to be re-created, because `node.marksAcross()` can return null (but `node.mark()` expects an array of marks).

marijnh commented 2017-12-13 09:24:56 +01:00 (Migrated from github.com)

Copy link

That makes sense, thanks for the patch. Merged as 3489bbe67 and released as prosemirror-state 1.0.2

That makes sense, thanks for the patch. Merged as 3489bbe67 and released as prosemirror-state 1.0.2

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

prosemirror/prosemirror-state!10

No description provided.