prosemirror/prosemirror-state
1
0
Fork 0
Code Pull requests Activity

Pass the root transaction to appendedTransaction meta #13

Closed
RichieAHB wants to merge 1 commit from rahb/appended-transaction-gets-root into master
pull from: rahb/appended-transaction-gets-root
merge into: prosemirror:master
Conversation 2 Commits 1 Files changed 2 +21 -4
RichieAHB commented 2018-07-12 17:02:04 +02:00 (Migrated from github.com)
Copy link

This passes the transaction that started all of the plugin transactions to appendedTransaction rather than a circular reference to itself, specifically for https://github.com/ProseMirror/prosemirror-history/pull/3 to fix ProseMirror/prosemirror#819

This passes the transaction that started all of the plugin transactions to `appendedTransaction` rather than a circular reference to itself, specifically for https://github.com/ProseMirror/prosemirror-history/pull/3 to fix ProseMirror/prosemirror#819
marijnh (Migrated from github.com) reviewed 2018-07-19 21:12:14 +02:00
test/test-state.js
@ -106,0 +119,4 @@
state.applyTransaction(tr)
})
it("stores a reference to a rootTransaction for appended transactions", () => {
marijnh (Migrated from github.com) commented 2018-07-19 21:12:14 +02:00
Copy link

The test below doesn't seem to be testing what the string here describes. Could it be that you flipped the test descriptions?

The test below doesn't seem to be testing what the string here describes. Could it be that you flipped the test descriptions?
marijnh commented 2018-07-23 15:18:19 +02:00 (Migrated from github.com)
Copy link

Merged as e598463f9 and cleaned up the test in d56dddadb4

Merged as e598463f9 and cleaned up the test in d56dddadb4019a65

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-state!13
No description provided.