Add step ranges

RichieAHB commented

2018-09-28 21:14:53 +02:00

(Migrated from github.com)

Had a quick look at this on the train, if it looks like it's going in the right direction I can add proper tests / doc strings (plus revisit any logic errors) but thought it better to throw this up.

If this looks ok then instead of prevMap inside the history plugin, there can be prevRanges which can be mapped for each appended transaction and then tested on new input with touches.

Had a quick look at this on the train, if it looks like it's going in the right direction I can add proper tests / doc strings (plus revisit any logic errors) but thought it better to throw this up. If this looks ok then instead of `prevMap` inside the history plugin, there can be `prevRanges` which can be mapped for each appended transaction and then tested on new input with `touches`.

marijnh commented

2018-10-08 12:43:35 +02:00

(Migrated from github.com)

I don't think this is a big enough use case to justify having another class exported from prosemirror-transform. I've committed a simpler solution to prosemirror-history, could you take a look whether it solves your use case?

RichieAHB commented

2018-10-08 12:59:28 +02:00

(Migrated from github.com)

That definitely makes sense just more terse, I’d actually thought to do something relatively similar to this but misunderstood you saying it might be worth making a smaller, easier to map version of a step - hence the class. Looks great!

marijnh commented

2018-10-08 13:28:12 +02:00

(Migrated from github.com)

Great. Did you test my change, to make sure we were actually talking about the same problem? If so, I'll release it.

RichieAHB commented

2018-10-08 13:32:26 +02:00

(Migrated from github.com)

I’m actually away this week so I don’t have my laptop. I read the intent of
the spec you wrote but I’m happy to test it when I’m back. The test looks
like it covers my exact case though.
On Mon, 8 Oct 2018 at 13:28, Marijn Haverbeke notifications@github.com
wrote:

Closed #12 https://github.com/ProseMirror/prosemirror-transform/pull/12.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ProseMirror/prosemirror-transform/pull/12#event-1890028948,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABk124jIjCO9acb-TQbji4kULCOl2x7yks5uizbQgaJpZM4W_a-9
.

I’m actually away this week so I don’t have my laptop. I read the intent of the spec you wrote but I’m happy to test it when I’m back. The test looks like it covers my exact case though. On Mon, 8 Oct 2018 at 13:28, Marijn Haverbeke <notifications@github.com> wrote: > Closed #12 <https://github.com/ProseMirror/prosemirror-transform/pull/12>. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/ProseMirror/prosemirror-transform/pull/12#event-1890028948>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABk124jIjCO9acb-TQbji4kULCOl2x7yks5uizbQgaJpZM4W_a-9> > . >

marijnh commented

2018-10-08 13:46:41 +02:00

(Migrated from github.com)

All right, going ahead and releasing this—you can open an issue if you run into problems

RichieAHB commented

2018-10-18 14:52:37 +02:00

(Migrated from github.com)

This actually fixes quite a few things for us, thanks!

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Rows
Columns

Add step ranges #12

Pull request closed