prosemirror/prosemirror-transform
1
0
Fork 0
Code Pull requests Activity

When close child size is 0, close() returned without changing #16

Closed
howyi wants to merge 1 commit from master into master
pull from: master
merge into: prosemirror:master
Conversation 1 Commits 1 Files changed 1 +4 -2
howyi commented 2021-01-14 13:50:13 +01:00 (Migrated from github.com)
Copy link

Related issue: https://github.com/outline/rich-markdown-editor/issues/233
https://github.com/outline/rich-markdown-editor/pull/252/files

github.com/ProseMirror/prosemirror-transform@3915231ad4
After this commit(> 1.2.5), "setBlockType ()" of "prosemirror-command" has a problem.

This is a fix for the problem that Node's Wrap is not working as shown in the image.
Specifically, the line you intended to change is deleted, and the line below is changed.

current

fixed(in this commit)

Related issue: https://github.com/outline/rich-markdown-editor/issues/233 https://github.com/outline/rich-markdown-editor/pull/252/files https://github.com/ProseMirror/prosemirror-transform/commit/3915231ad4dca4c40892173ee509d268b685e19d After this commit(> 1.2.5), "setBlockType ()" of "prosemirror-command" has a problem. This is a fix for the problem that Node's Wrap is not working as shown in the image. Specifically, the line you intended to change is deleted, and the line below is changed. current ![](https://i.gyazo.com/e7f41fe68d4d637f2510882c3032d11a.gif) fixed(in this commit) ![](https://i.gyazo.com/5a3a8d534bafa0cc818a30cd2da101f6.gif)
marijnh commented 2021-01-14 15:15:22 +01:00 (Migrated from github.com)
Copy link

Would it be possible to add a test that fails with the current code but passes with this patch in test/test-trans.js?

Would it be possible to add a test that fails with the current code but passes with this patch in test/test-trans.js?

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-transform!16
No description provided.