prosemirror/prosemirror-transform
1
0
Fork 0
Code Pull requests Activity

Update replace_step.js #19

Closed
jindw wants to merge 2 commits from master into master
pull from: master
merge into: prosemirror:master
Conversation 3 Commits 2 Files changed 1 +3 -1
jindw commented 2021-10-22 10:21:54 +02:00 (Migrated from github.com)
Copy link

fix gap range : gapFrom = min(from,gapFrom), gapTo=max(to,gapTo)

if the external boundary is reached, there will be no deletion, right？Are there any other ignored problems?

fix gap range : gapFrom = min(from,gapFrom), gapTo=max(to,gapTo) ------- if the external boundary is reached, there will be no deletion, right？Are there any other ignored problems?
👍 2
marijnh commented 2021-10-24 14:48:52 +02:00 (Migrated from github.com)
Copy link

What problem does this patch solve?

What problem does this patch solve?
jindw commented 2021-10-25 08:28:52 +02:00 (Migrated from github.com)
Copy link

What problem does this patch solve?

ReplaceAroundStep data loss during offline collaborative editing [#1216]

> What problem does this patch solve? [ReplaceAroundStep data loss during offline collaborative editing [#1216]](https://github.com/ProseMirror/prosemirror/issues/1216)
jindw (Migrated from github.com) reviewed 2021-10-25 08:31:17 +02:00
jindw (Migrated from github.com) left a comment
Copy link

Sorry, the first patch has a low-level syntax error：

line 146

if ((from.deleted && to.deleted) return null

fixed to:

if (from.deleted && to.deleted) return null

Sorry, the first patch has a low-level syntax error： line 146 if ((from.deleted && to.deleted) return null fixed to: if (from.deleted && to.deleted) return null

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-transform!19
No description provided.