prosemirror/prosemirror-transform
1
0
Fork 0
Code Pull requests Activity

Resolve: You cannot cancel multiple marks at the same time in a paragraph where there are already multiple marks #23

Closed
littersnaker wants to merge 1 commit from master into master
pull from: master
merge into: prosemirror:master
Conversation 4 Commits 1 Files changed 1 +1 -1
littersnaker commented 2023-04-21 06:07:54 +02:00 (Migrated from github.com)
Copy link

… where there are already multiple marks

… where there are already multiple marks
marijnh commented 2023-04-21 08:14:32 +02:00 (Migrated from github.com)
Copy link

This change looks very suspicious. You're going to have to at least describe the problem you're trying to solve here properly.

This change looks very suspicious. You're going to have to at least describe the problem you're trying to solve here properly.
littersnaker commented 2023-05-19 09:59:09 +02:00 (Migrated from github.com)
Copy link

This branch solves the problem that only one of the marks will be canceled when clicking on the corresponding mark in the middle of the field that has been underlined and bolded italics on the official website

This branch solves the problem that only one of the marks will be canceled when clicking on the corresponding mark in the middle of the field that has been underlined and bolded italics on the official website
marijnh commented 2023-05-19 10:55:31 +02:00 (Migrated from github.com)
Copy link

That's still not very specific. The way I understand it is you've made some bold+italic text in the demo on the website, put the cursor in there, and click off the buttons for bold and italic in the menu bar. If I do that and then type, I get plain, unmarked text.

That's still not very specific. The way I understand it is you've made some bold+italic text in the demo on the website, put the cursor in there, and click off the buttons for bold and italic in the menu bar. If I do that and then type, I get plain, unmarked text.
littersnaker commented 2023-05-23 10:55:26 +02:00 (Migrated from github.com)
Copy link

I just tried the operation I mentioned on the official website and indeed obtained a plain text font. However, in the Tiptap project, we can only cancel one of the marks before. We may need to wait for them to update the version before looking at it. I will merge and close this first. Thank you for your reply

I just tried the operation I mentioned on the official website and indeed obtained a plain text font. However, in the Tiptap project, we can only cancel one of the marks before. We may need to wait for them to update the version before looking at it. I will merge and close this first. Thank you for your reply

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-transform!23
No description provided.