prosemirror/prosemirror-transform
1
0
Fork 0
Code Pull requests Activity

dont mutate maps or mirror #28

Closed
BrianHung wants to merge 1 commit from mapping-immutable-maps-mirror-arrays into master
pull from: mapping-immutable-maps-mirror-arrays
merge into: prosemirror:master
Conversation 2 Commits 1 Files changed 1 +5 -4
BrianHung commented 2024-10-25 09:04:41 +02:00 (Migrated from github.com)
Copy link

Was reverting tracked changes and noticed that appendMap mutates the original array passed into new Mapping. Doesn't happen in the example code but happened in my codebase where I didn't defensively clone the maps array.

Was [reverting tracked changes](https://github.com/ProseMirror/website/blob/09f795d07f3717f2041a9936df4f052b381f90aa/example/track/index.js#L257) and noticed that `appendMap` mutates the original array passed into `new Mapping`. Doesn't happen in the example code but happened in my codebase where I didn't defensively clone the maps array.
marijnh commented 2024-10-25 18:16:14 +02:00 (Migrated from github.com)
Copy link

I don't think this is a good idea. It will make building up bigger maps with appendMap take quadratic time, and generally introduce a lot of unnecessary copies. Does attached patch look like a reasonable solution?

I don't think this is a good idea. It will make building up bigger maps with `appendMap` take quadratic time, and generally introduce a lot of unnecessary copies. Does attached patch look like a reasonable solution?
👍 1
BrianHung commented 2024-10-25 20:13:14 +02:00 (Migrated from github.com)
Copy link

Yep, copying the original array once when appendMap is called for the first time works too.

Yep, copying the original array once when `appendMap` is called for the first time works too.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-transform!28
No description provided.