Add MarkView.destroy #174

Merged

ocavue merged 6 commits from ocavue/markview-destroy into master

2024-11-03 13:49:46 +01:00

ocavue commented

2024-11-01 07:44:37 +01:00

(Migrated from github.com)

This PR implements the destroy() method for mark views, which is required for rendering mark with other UI framework like React. See also https://discuss.prosemirror.net/t/support-destroy-method-in-markview/7855

This PR implements the `destroy()` method for mark views, which is required for rendering mark with other UI framework like React. See also https://discuss.prosemirror.net/t/support-destroy-method-in-markview/7855

👍 1

marijnh (Migrated from github.com) reviewed

2024-11-01 07:44:37 +01:00

marijnh (Migrated from github.com) reviewed

2024-11-03 10:45:17 +01:00

src/viewdesc.ts

TypeScript, with our build settings, still produces much worse code for a ?.() call than this conditional. Could you rever this and also use an if in MarkView.destroy?

TypeScript, with our build settings, still produces much worse code for a `?.()` call than this conditional. Could you rever this and also use an `if` in `MarkView.destroy`?