prosemirror/prosemirror-view
1
2
Fork 0
Code Pull requests Activity

fix: add ariaHidden to br hack nodes #180

Closed
nperez0111 wants to merge 1 commit from trailing-break-hidden into master
pull from: trailing-break-hidden
merge into: prosemirror:master
Conversation 5 Commits 1 Files changed 1 +4 -1
nperez0111 commented 2025-04-17 08:38:04 +02:00 (Migrated from github.com)
Copy link

In the same spirit as https://github.com/ProseMirror/prosemirror-view/pull/118 this makes the BR hack node be hidden to screen readers

In the same spirit as https://github.com/ProseMirror/prosemirror-view/pull/118 this makes the BR hack node be hidden to screen readers
marijnh commented 2025-04-18 18:03:09 +02:00 (Migrated from github.com)
Copy link

These nodes are present in most web-based editors, and screen readers seem to be able to handle them gracefully in my experience. What kind of issues are you running into, when using a screen reader, that would require this attribute?

These nodes are present in most web-based editors, and screen readers seem to be able to handle them gracefully in my experience. What kind of issues are you running into, when using a screen reader, that would require this attribute?
miguelcaro commented 2025-04-24 15:30:20 +02:00 (Migrated from github.com)
Copy link

@marijnh one of our clients report that the
it is been announced by the screen reader.
please take a look on the following image

Screenshot 2025-04-24 at 8 23 43 AM

c.c. @nperez0111

@marijnh one of our clients report that the <br> it is been announced by the screen reader. please take a look on the following image <img width="904" alt="Screenshot 2025-04-24 at 8 23 43 AM" src="https://github.com/user-attachments/assets/a5bd3f9d-f045-49f5-affd-1af7f8dc0f1a" /> c.c. @nperez0111
marijnh commented 2025-04-25 09:31:15 +02:00 (Migrated from github.com)
Copy link

How does the reader announce these? What do they sound like?

How does the reader announce these? What do they sound like?
miguelcaro commented 2025-04-25 17:07:25 +02:00 (Migrated from github.com)
Copy link

How does the reader announce these? What do they sound like?

Don't know to be honest they just sent us this image with
been announced by the NVDA speech viewer, like you can see in the image above

> How does the reader announce these? What do they sound like? Don't know to be honest they just sent us this image with <Br> been announced by the NVDA speech viewer, like you can see in the image above
marijnh commented 2025-04-25 20:07:08 +02:00 (Migrated from github.com)
Copy link

What I'm seeing with NVDA is that it says 'blank' on blank lines, whether they have the <br> or not, and nothing more. Until I actually understand the problem, I'm afraid I'm not going to merge this patch.

What I'm seeing with NVDA is that it says 'blank' on blank lines, whether they have the `<br>` or not, and nothing more. Until I actually understand the problem, I'm afraid I'm not going to merge this patch.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-view!180
No description provided.