prosemirror/prosemirror-view
1
2
Fork 0
Code Pull requests Activity

Fix missing transaction on readDOMChange #186

Merged
KentoMoriwaki merged 1 commit from kento/fix-handle-inline-change into master 2025-10-07 10:25:07 +02:00
Conversation 3 Commits 1 Files changed 1 +2
KentoMoriwaki commented 2025-10-07 09:54:29 +02:00 (Migrated from github.com)
Copy link

When I upgraded prosemirror-view from 1.37.0 to 1.41.0 in my application, I encountered an unexpected change. With a selection spanning multiple nodes, typing any character used to replace the selected range with the input. In the new version, the change is ignored and nothing happens.

Tracing the changes to find the cause, I discovered that the following commit introduced a case where a transaction that used to be dispatched is no longer dispatched. Applying this change locally restored the previous behavior.
github.com/ProseMirror/prosemirror-view@7a6f6e8b86 (diff-310a73fb2a)

I tried to create a reproducible repository, but the conditions are complex and I couldn’t reproduce it in isolation. If this change is straightforward, I’d appreciate it being merged.

When I upgraded prosemirror-view from 1.37.0 to 1.41.0 in my application, I encountered an unexpected change. With a selection spanning multiple nodes, typing any character used to replace the selected range with the input. In the new version, the change is ignored and nothing happens. Tracing the changes to find the cause, I discovered that the following commit introduced a case where a transaction that used to be dispatched is no longer dispatched. Applying this change locally restored the previous behavior. https://github.com/ProseMirror/prosemirror-view/commit/7a6f6e8b8656fc6979a11a4730032e847f00cf3a#diff-310a73fb2a0b23f8c1355aab99401a86d9ae5d5b51116f2520c5302fe36b29f6L245 I tried to create a reproducible repository, but the conditions are complex and I couldn’t reproduce it in isolation. If this change is straightforward, I’d appreciate it being merged.
marijnh commented 2025-10-07 10:25:24 +02:00 (Migrated from github.com)
Copy link

Thanks for the fix! Merged.

Thanks for the fix! Merged.
KentoMoriwaki commented 2025-10-08 10:45:08 +02:00 (Migrated from github.com)
Copy link

Are you going to release a new version?

Are you going to release a new version?
marijnh commented 2025-10-09 07:43:18 +02:00 (Migrated from github.com)
Copy link

I've tagged a 1.41.3

I've tagged a 1.41.3
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-view!186
No description provided.