Search extension behaviors #496 #2

Closed

rdesille wants to merge 3 commits from main into main

pull from: main

merge into: codemirror:main

Conversation 1 Commits 3 Files changed 1 +29 -9

rdesille commented 2021-05-26 18:00:55 +02:00 (Migrated from github.com)

Copy link

As discussed (#496), here a proposal of implementation.

As discussed ([#496](https://github.com/codemirror/codemirror.next/issues/496)), here a proposal of implementation.

marijnh commented 2021-05-27 10:43:43 +02:00 (Migrated from github.com)

Copy link

I ended up implementing this slightly differently (setting the query state directly, rather than going through the DOM field) in 990908f0c9 and 1008d1a8b4.

I ended up implementing this slightly differently (setting the query state directly, rather than going through the DOM field) in 990908f0c995737 and 1008d1a8b4aebcd3.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/search!2

No description provided.